Set minimum timestamp of partitions properly #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression that caused partitions created by the partition transformer to have a minimum timestamp of the epoch when the transformation pipeline created new table slices, i.e., lost the original import timestamp as part of the executed pipeline.
The catalog already gets its schemas from the partition synopses, so there's no need to send it the schemas individually. This was previously needed when type registry and catalog were separate.
|
I believe we need to adjust the initial value of diff --git a/libvast/include/vast/system/partition_transformer.hpp b/libvast/include/vast/system/partition_transformer.hpp
index e9f8d5a770..e79184775e 100644
--- a/libvast/include/vast/system/partition_transformer.hpp
+++ b/libvast/include/vast/system/partition_transformer.hpp
@@ -103,10 +103,10 @@ struct partition_transformer_state {
size_t events = 0ull;
/// Oldest import timestamp of the input data.
- vast::time min_import_time = {};
+ vast::time min_import_time = vast::time::max();
/// Newest import timestamp of the input data.
- vast::time max_import_time = {};
+ vast::time max_import_time = vast::time::min();
/// The data of the newly created partition(s).
std::multimap<type, active_partition_state::serialization_data> data = {};
|
tobim
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that caused partitions created by the partition transformer to have a minimum timestamp of the epoch when the transformation pipeline created new table slices, i.e., lost the original import timestamp as part of the executed pipeline.