-
-
Notifications
You must be signed in to change notification settings - Fork 95
Implement a sort
operator
#3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a very basic implementation of a sort operator that comes with a few fundamental limitations: - All data is kept in memory - There is no windowing support - Extension types are not supported for sorting (ip, subnet, enum). - Sorting only works by one column at a time - The resulting slices of the operator have a size of 1, which leads to very slow data access in following operators But other than that it works as you'de xpect.
0cd6583
to
61528b9
Compare
@dominiklohmann I pushed a commit with an updated documentation. |
One thing I noticed during testing: just |
Added another commit to test |
The sensible default if the field is omitted is likely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this works as expected. I added tests and they now work.
Unfortunately I lack the Arrow depth to review what the code does in detail. If you need a second pair of eyes from @tenzir/pipelines-squad, I'd ask there. Otherwise my approval is only based on high-level skimming and testing.
This is a very basic implementation of a sort operator that comes with a few fundamental limitations:
But other than that it works as you'd expect.
Tasks