Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename #type to #schema and introduce #schema_id #3183

Merged
merged 9 commits into from Jun 1, 2023
Merged

Rename #type to #schema and introduce #schema_id #3183

merged 9 commits into from Jun 1, 2023

Conversation

jachris
Copy link
Contributor

@jachris jachris commented May 31, 2023

No description provided.

@jachris jachris force-pushed the topic/meta-rename-to-schema branch from d1154b2 to da6467d Compare May 31, 2023 10:05
@jachris jachris added the feature New functionality label May 31, 2023
@jachris jachris marked this pull request as ready for review May 31, 2023 10:09
dominiklohmann
dominiklohmann reviewed May 31, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast. I left two comments for your two TODOs, which I think should be addressed. I'd then like to take another look, but this should be good to go otherwise.

libvast/src/system/catalog.cpp Outdated Show resolved Hide resolved
libvast/include/vast/detail/partition_common.hpp Outdated Show resolved Hide resolved
dominiklohmann
dominiklohmann approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! Let's get this merged quickly so you don't have to resolve many merge conflicts for this.

@jachris jachris force-pushed the topic/meta-rename-to-schema branch from 40b57be to 8eaa392 Compare May 31, 2023 15:07
@jachris jachris enabled auto-merge May 31, 2023 15:11
@dominiklohmann
Limit regression tests to the next version
b203e48 
We introduced a breaking change that is not backwards-compatible, so
from now on the regression tests will only cover v4.0.0 and upwards, but
also include the version from the PR itself.
@dominiklohmann
Remove old regression test workaround
5c905fc
@dominiklohmann
Merge branch 'main' into topic/meta-rename-to-schema
1693338
@dominiklohmann
Copy link
Member

I'm merging this with a manual CI override because the regression test for latest cannot succeed before this is actually merged and the image was uploaded once on main.

@dominiklohmann dominiklohmann merged commit d7a4a00 into main Jun 1, 2023
29 of 33 checks passed
@dominiklohmann dominiklohmann deleted the topic/meta-rename-to-schema branch June 1, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
2 participants
@jachris @dominiklohmann