Change Arrow extension type and metadata prefixes #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/rename-arrow-ext-type-and-metadata
branch
2 times, most recently
from
465f8d0
to
1bf8515
Compare
We now register extension types as `tenzir.ip`, `tenzir.subnet`, and `tenzir.enumeration` instead of `vast.address`, `vast.subnet`, and `vast.enumeration`, respectively. Type metadata now has a `Tenzir:` prefix instead of a `VAST:` prefix. The change is mostly backwards compatible. The old type names and prefixes are still supported. However, reading old Apache Feather V2 and Apache Parquet inside the database directory files using the Pythin bindings will not work until a `tenzir-ctl rebuild --all` was run.
dominiklohmann
force-pushed
the
topic/rename-arrow-ext-type-and-metadata
branch
from
1bf8515
to
9c1d4ad
Compare
If you want to read the files using our Python Arrow extension types, then yes, otherwise no. |
That seems like a reasonable tradeoff. |
This seems to be the norm, e.g., Arrow's own metadata is `ARROW:`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now register extension types as
tenzir.ip,tenzir.subnet, andtenzir.enumerationinstead ofvast.address,vast.subnet, andvast.enumeration, respectively. Type metadata now has aTenzir:prefix instead of aVAST:prefix.The change is mostly backwards compatible. The old type names and prefixes are still supported. However, reading old Apache Feather V2 and Apache Parquet inside the database directory files using the Python bindings will not work until a
tenzir-ctl rebuild --allwas run.