Skip to content

Refactor show aspects and rewrite version #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 11, 2023
Merged

Refactor show aspects and rewrite version #3442

merged 17 commits into from
Aug 11, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented Aug 7, 2023 •
edited
Loading

This PR makes show aspects first-class citizens so that users can write plugins for it.

Moreover, the PR decomposes the version operator into several show aspects for easier and more idiomatic consumption.

### Tasks
- [x] Make plugins out of aspects
- [x] Refactor `version` into aspects
- [x] Add changelog entry
- [x] Update docs

mavam added 2 commits August 7, 2023 16:27
@mavam
Make aspects first-class plugins
7a6fc92
@mavam
Split up version operation into show aspects
6d49fd9 
The 'version' operator accumulated several different things that are somewhat
unrelated. This commit replaces 'version' with several 'show' aspects:

  - build
  - dependencies
  - plugins
  - version
@mavam mavam added refactoring Restructuring of existing code engine Core pipeline and storage engine labels Aug 8, 2023
@mavam mavam requested a review from dominiklohmann August 10, 2023 16:15
@mavam mavam enabled auto-merge August 10, 2023 21:38
dominiklohmann
dominiklohmann approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very nicely. As discussed I pushed my review feedback directly.

dominiklohmann
dominiklohmann reviewed Aug 10, 2023
View reviewed changes
@mavam mavam merged commit d50e23d into main Aug 11, 2023
@mavam mavam deleted the topic/aspect-plugin branch August 11, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
engine Core pipeline and storage engine refactoring Restructuring of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavam @dominiklohmann