Disable dense indexes #3552
Merged
Disable dense indexes #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent release already disabled string indexes, which were using memory very inefficiently. This now generally disables all dense indexes, which have lost most of their appeal with columnar expression evaluation becoming more and more efficient. The recent addition of the null type and empty records forced us to take another look at dense indexes, and we internally made the unbureaucratic decision not to want to maintain them any longer.
dominiklohmann
force-pushed
the
topic/disable-dense-indexes
branch
from
e300094
to
249bf6f
Compare
mavam
approved these changes
Oct 7, 2023
Models were fundamentally broken in query evaluation, and no one noticed—which is usually a sign that a feature can be removed without much user friction. We already have plans to bring the feature back through more powerful expressions in TQL.
dominiklohmann
force-pushed
the
topic/disable-dense-indexes
branch
from
f03b023
to
84e1676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent release already disabled string indexes, which were using memory very inefficiently. This now generally disables all dense indexes, which have lost most of their appeal with columnar expression evaluation becoming more and more efficient.
The recent addition of the null type and empty records forced us to take another look at dense indexes, and we internally made the unbureaucratic decision not to want to maintain them any longer.
Fixes tenzir/issues#917