Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade remaining usages of the adaptive table slice builder #3582

Merged
merged 10 commits into from Oct 18, 2023
Merged

Upgrade remaining usages of the adaptive table slice builder #3582

merged 10 commits into from Oct 18, 2023

Conversation

jachris
Copy link
Contributor

@jachris jachris commented Oct 17, 2023 •
edited

This could have still waited a bit, but it will make #3581 easier.

@dominiklohmann
Add events field to output of show partitions
81d4b9f 
One simple use case for this is wanting to see how many events are
stored at the node per schema.

```
show partitions
| summarize events=sum(events) by schema
| sort events desc
```
@jachris jachris added the refactoring Restructuring of existing code label Oct 17, 2023
@jachris jachris force-pushed the topic/upgrade-remaining-builders branch 2 times, most recently from 80806ad to 3a138de Compare October 18, 2023 07:36
@jachris jachris marked this pull request as ready for review October 18, 2023 07:36
@jachris jachris marked this pull request as draft October 18, 2023 07:37
@jachris jachris force-pushed the topic/upgrade-remaining-builders branch 2 times, most recently from 3c99a86 to 2a6ea81 Compare October 18, 2023 07:56
@jachris jachris force-pushed the topic/upgrade-remaining-builders branch from 2a6ea81 to 84ffd7d Compare October 18, 2023 07:59
@jachris jachris marked this pull request as ready for review October 18, 2023 08:00
dominiklohmann
dominiklohmann approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look really obvious to me. Feels good to see so much code deleted. 🎉

@jachris jachris force-pushed the topic/upgrade-remaining-builders branch from 31c57b3 to e3e187d Compare October 18, 2023 09:28
@jachris jachris force-pushed the topic/upgrade-remaining-builders branch from ad1cdc9 to 9dffe83 Compare October 18, 2023 11:05
@jachris jachris merged commit 75485c5 into main Oct 18, 2023
39 checks passed
@jachris jachris deleted the topic/upgrade-remaining-builders branch October 18, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
refactoring Restructuring of existing code
Projects
None yet
Milestone
No milestone
2 participants
@jachris @dominiklohmann