Fix predicate pushdown in export and other small fixes
#3599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
dominiklohmann
force-pushed
the
topic/predicate-pushdown
branch
from
e2c8653 to
b06773d
Compare
tobim
approved these changes
Oct 25, 2023
dominiklohmann
commented
Oct 25, 2023
dominiklohmann
force-pushed
the
topic/predicate-pushdown
branch
3 times, most recently
from
36453f5 to
c527abd
Compare
This was a tricky one: With the recent changes to the behavior of await in CAF that we backported, we had to switch to using `send` for the internal run loop. That, however, unlike the direct scheduling on the clock we used previously, can keep an actor alive. The scheduling of a new run that this commit removes was unnecessary, and in fact actively harmful as it led to an infinite loop during shutdown of an operator when the timing was just right.
dominiklohmann
force-pushed
the
topic/predicate-pushdown
branch
from
c527abd to
4cda9aa
Compare
The expected debug representation for an optimized `export | where …` changed with this PR, so we must also update the references accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is five fixes in one PR:
export | where …#3590serveexiting prematurely #3562 that caused operators to sometimes hang on shutdown; this mostly occurred in release builds with high-volume pipelines at the process boundary (no changelog entry for this one as we never released with this bug)--skip-emptyforread linesnow works as expectedshow build