New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export --internal
to access metrics
#3619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
f6af1c7
to
d8b7c67
Compare
I still have to write the docs for the actual metrics events, but besides that, this should be ready for review. |
d8b7c67
to
d3c6f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two initial comments on the docs to start a discussion; still reviewing the code changes.
2b2efc2
to
07ae815
Compare
07ae815
to
327c2b9
Compare
This PR makes it so that we store pipeline metrics in the database. They are marked as "internal", which means that they are not exported by default. Instead, we can use
export --internal
to do so. The implementation uses a#internal
meta extractor as a marker, but this extractor can only be accessed from code and not user-written pipelines.It also fixes a bug where
export --live | where <filter>
discarded the filter.Example
Tasklist
internal
flag to event data(to be done later)export --live --internal
does not work yet