New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syslog
parser
#3645
Merged
Merged
Add syslog
parser
#3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaskosunen
force-pushed
the
topic/syslog-parser
branch
2 times, most recently
from
November 16, 2023 14:11
735ebb4
to
4c8f248
Compare
I'll still need to add a changelog entry, and a new format to the docs. |
jachris
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for continuing this 🙏 Below are just some first reactions.
eliaskosunen
force-pushed
the
topic/syslog-parser
branch
from
November 17, 2023 11:47
0ada527
to
6b335e7
Compare
jachris
approved these changes
Nov 20, 2023
eliaskosunen
force-pushed
the
topic/syslog-parser
branch
from
November 20, 2023 10:11
6b335e7
to
bd3ce21
Compare
jachris
reviewed
Nov 21, 2023
eliaskosunen
force-pushed
the
topic/syslog-parser
branch
2 times, most recently
from
November 21, 2023 09:19
3962bb2
to
9ea4bbc
Compare
jachris
reviewed
Nov 21, 2023
eliaskosunen
force-pushed
the
topic/syslog-parser
branch
from
November 21, 2023 11:49
9ea4bbc
to
5a038ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the
syslog
format already implemented, to add support for RFC 3164 -compliant(ish) syslogs, calledlegacy_syslog
in the code. RFC 5424 support was already implemented.Alongside that, a
syslog
plugin is added, which can be used to parse syslogs as a part of a pipeline.Possible extensions (to do here, or in a separate PR):