Add 'min_events' parameters to /serve endpoint #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
topic/serve-min-events
branch
from
f4110b1
to
4353733
Compare
dominiklohmann
approved these changes
Nov 22, 2023
lava
force-pushed
the
topic/serve-min-events
branch
from
b5e5805
to
cdcc6b7
Compare
|
As with most other recent PRs, I'm ignoring the brew-related errors on the macOS plugin builds, since this PR does not touch any code related to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter 'min_events' to the
/serveendpoint, with the semantics that the endpoint will return a result as soon asmin_eventsevents have arrived, regardless of the configuredtimeoutandmax_events.The idea is to allow long polling, by specifying a long timeout and a low value for
min_events. The defaults for the endpoint are adjusted accordingly.