New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement context backends for the contextualizer #3684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This context can be used to enrich events with constant fields that are defined with the context create operator: ``` context create myconstants --type constants foo=bar ```
…rray> return type
We do not want to count egress or ingress for discard, export, and import. This makes it so their metrics are specifically annotated to be internal, as they are technically not ingress or egress.
Dakostu
force-pushed
the
topic/contextulization
branch
from
November 29, 2023 09:09
7e04a6d
to
24e937f
Compare
Dakostu
force-pushed
the
topic/contextulization
branch
from
November 29, 2023 09:51
72d4693
to
736bad3
Compare
Dakostu
force-pushed
the
topic/contextulization
branch
from
November 29, 2023 16:14
ed0767d
to
97812e6
Compare
…ntextulization
Dakostu
force-pushed
the
topic/contextulization
branch
from
November 30, 2023 08:26
97812e6
to
0e50004
Compare
Dakostu
force-pushed
the
topic/contextulization
branch
from
November 30, 2023 13:01
a828d9d
to
50a9bd7
Compare
…ntextulization
dominiklohmann
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last question, then I think this is ready to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements context backends for the contextualizer.
TODO: Tests.