Improve metrics collection #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
engine
dominiklohmann
force-pushed
the
topic/redo-metrics
branch
from
4c6444b
to
996f5fc
Compare
This rewrites the _metrics collector_ component from the ground up to be much simpler. Metrics plugins can now specify the frequency at which they want to emit metrics, defaulting to one second, and the metrics are collected every thirty seconds. Previously, metrics were collected every ten seconds and then immediately sent out in batches of exactly one event. Additionally, this implements memory metrics on macOS.
dominiklohmann
force-pushed
the
topic/redo-metrics
branch
from
996f5fc
to
abdabcf
Compare
jachris
approved these changes
Feb 26, 2024
Co-authored-by: Jannis Christopher Köhl <mail@koehl.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the metrics collector component from the ground up to be much simpler. Metrics plugins can now specify the frequency at which they want to emit metrics, defaulting to one second, and the metrics are collected every thirty seconds. Previously, metrics were collected every ten seconds and then immediately sent out in batches of exactly one event.
Additionally, this implements memory metrics on macOS.