Allow using and, or, and not in expressions
#3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
language
jachris
approved these changes
Mar 1, 2024
This change makes it so that `X or not (Y and Z)` is equivalent to `X || !(Y && Z)`. Since we want to move to that anyways with TQL2 and I'm constantly mistyping this already, I figured it'd make sense to introduce this four line diff that's entirely backwards-compatible to allow using the new tokens for conjunctions, disjunctions, and negations already. This also removes the undocumented and untested `[+`, `[-`, `+]`, and `-]` relational operators that were aliases for `in`, `not in`, `ni`, and `not ni`, respectively. It's odd when you find code after over four years of contributing to a project that's just silently been there and that you've never seen. I doubt anyone is going to miss them.
dominiklohmann
force-pushed
the
topic/alternative-tokens-old-exprs
branch
from
5a10a76
to
03e265d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that
X or not (Y and Z)is equivalent toX || !(Y && Z). Since we want to move to that anyways with TQL2 and I'm constantly mistyping this already, I figured it'd make sense to introduce this four line diff that's entirely backwards-compatible to allow using the new tokens for conjunctions, disjunctions, and negations already.This also removes the undocumented and untested
[+,[-,+], and-]relational operators that were aliases forin,not in,ni, andnot ni, respectively. It's odd when you find code after over four years of contributing to a project that's just silently been there and that you've never seen. I doubt anyone is going to miss them.