Fix a TOCTOU bug that caused the index to fail #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
This fixes a bug that sometimes caused the index actor to shut down with an exception when combined with compaction or the disk monitor because of a time of check vs. time of use bug when trying to canonicalize paths in the returned partition infos from the catalog lookup.
dominiklohmann
force-pushed
the
topic/index-toctou
branch
from
60be313
to
4894b75
Compare
tobim
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that sometimes caused the index actor to shut down with an exception when combined with compaction or the disk monitor because of a time of check vs. time of use bug when trying to canonicalize paths in the returned partition infos from the catalog lookup.