Fix partial specialization of S3 configuration in URL #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/fix-s3-config-overrides
branch
from
0ea8ba4
to
b49d6dc
Compare
dominiklohmann
commented
Mar 7, 2024
This fixes partial overrides of the S3 configuration in the arguments to the URL. Previously, when providing any arguments to the S3 connector as part of the URL, it failed to respect the default credentials from the configuration file. Additionally, this makes it possible to specify the S3 secrets in the S3 plugin's configuration file directly.
dominiklohmann
force-pushed
the
topic/fix-s3-config-overrides
branch
from
b49d6dc
to
9c0b153
Compare
dominiklohmann
requested review from
lava and
Dakostu
and removed request for
a team
Dakostu
requested changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes partial overrides of the S3 configuration in the arguments to the URL. Previously, when providing any arguments to the S3 connector as part of the URL, it failed to respect the default credentials from the configuration file.
Additionally, this makes it possible to specify the S3 secrets in the S3 plugin's configuration file directly.