Fix loading of large contexts #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaskosunen
added
bug
eliaskosunen
force-pushed
the
topic/chunked-context-load
branch
from
0141728
to
cfd8d28
Compare
jachris
approved these changes
Mar 13, 2024
jachris
reviewed
Mar 13, 2024
eliaskosunen
force-pushed
the
topic/chunked-context-load
branch
2 times, most recently
from
82b264a
to
3b18efd
Compare
eliaskosunen
force-pushed
the
topic/chunked-context-load
branch
from
3b18efd
to
ae8eb10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a logic bug in
context load, where each chunk of the input was attempted to be loaded individually, rather than loading the entire input. This error was only encountered, when loading contexts that were large enough to be split into multiple chunks.Plugins PR https://github.com/tenzir/tenzir-plugins/pull/210