Fix an off-by-one error when loading persisted contexts #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
dominiklohmann
force-pushed
the
topic/context-load-off-by-one
branch
from
f369e39
to
954b7f8
Compare
mavam
approved these changes
Mar 16, 2024
dominiklohmann
force-pushed
the
topic/context-load-off-by-one
branch
from
954b7f8
to
5420528
Compare
This fixes a nasty off-by-one error when loading persisted contexts that reliably led to every second context to be skipped when loading from disk.
dominiklohmann
force-pushed
the
topic/context-load-off-by-one
branch
from
5420528
to
f1b33f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty off-by-one error when loading persisted contexts that reliably led to every second context to be skipped when loading from disk.