Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDP connector #4067

Merged
merged 21 commits into from Mar 27, 2024
Merged

Add UDP connector #4067

merged 21 commits into from Mar 27, 2024

Conversation

mavam
Copy link
Member

@mavam mavam commented Mar 24, 2024 •
edited

This PR adds a UDP connector.

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Add loader
    Options
  2. Support hostname resolution
    Options
  3. Support IPv6
    Options
  4. Write docs
    Options
  5. Fix off-by-one hang
    Options
  6. Add saver
    Options
  7. Add integration tests
    Options
  8. Add changelog entry
    Options

@mavam mavam added feature New functionality connector Loader and saver labels Mar 24, 2024
@mavam mavam marked this pull request as ready for review March 26, 2024 15:39
dominiklohmann
dominiklohmann approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in practice. I left a few comments inline that should be addressed, but they're of minor nature only.

libtenzir/builtins/connectors/udp.cpp Outdated Show resolved Hide resolved
libtenzir/include/tenzir/as_bytes.hpp Show resolved Hide resolved
web/docs/connectors/udp.md Outdated Show resolved Hide resolved
@mavam mavam enabled auto-merge March 27, 2024 13:31
@mavam mavam merged commit 6fc8bdc into main Mar 27, 2024
51 checks passed
@mavam mavam deleted the topic/udp-connector branch March 27, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
connector Loader and saver feature New functionality
Projects
None yet
Milestone
No milestone
2 participants
@mavam @dominiklohmann