Support parallel connections in from tcp
#4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
feature
dominiklohmann
force-pushed
the
topic/accept-decorator
branch
from
dfe0330
to
8d4b1bf
Compare
dominiklohmann
changed the title
accept operatorfrom tcp
dominiklohmann
changed the title
from tcpfrom tcp
dominiklohmann
force-pushed
the
topic/accept-decorator
branch
from
a1e121f
to
33b976f
Compare
|
When someone tries to connect to a TLS socket with the wrong handshake the pipeline terminates. client: |
dominiklohmann
added a commit
that referenced
this pull request
Apr 6, 2024
With recent improvements to `from tcp` from #4084 this script is no longer needed.
dominiklohmann
added a commit
that referenced
this pull request
Apr 6, 2024
With recent improvements to `from tcp` from #4084 this script is no longer needed.
dominiklohmann
added a commit
that referenced
this pull request
Apr 7, 2024
With recent improvements to `from tcp` from #4084 this script is no longer needed.
dominiklohmann
added a commit
that referenced
this pull request
Apr 7, 2024
With recent improvements to `from tcp` from #4084 this script is no longer needed.
lava
reviewed
Apr 8, 2024
dominiklohmann
commented
Apr 8, 2024
This is a horrible hack: `from tcp` now replaces itself with `tcp-listen` (renamed from `accept`) under the hood; however, if `--connect` or `--listen-once` are specified, the `tcp-listen` operator again replaces itself with `load tcp | read …` to achieve the desired behavior.
dominiklohmann
force-pushed
the
topic/accept-decorator
branch
from
3f5721a
to
053094e
Compare
dominiklohmann
force-pushed
the
topic/accept-decorator
branch
from
053094e
to
b895b3c
Compare
tobim
force-pushed
the
topic/accept-decorator
branch
from
f19d95c
to
91c1dfc
Compare
tobim
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new internal and undocumented
tcp-listen <endpoint> read <format>operator accepts multiple TCP connections on the specified endpoint, and for each creates a parser of the specified format, returning the events into the pipeline.The
fromoperator intelligently dispatches to thetcp-listenendpoint to allow listening from accepting multiple connections in parallel, which is not possible to implement through the connector APIs alone.