Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown of connected pipelines alongside node #4093

Merged
merged 1 commit into from Apr 5, 2024

Conversation

dominiklohmann
Copy link
Member

In some cases, pipelines created with a tenzir process connected to a tenzir-node process did not shut down correctly when the tenzir-node process was terminated. This change makes it so that remotely spawned operators are always shut down reliably.

Fixes tenzir/issues#1712

@dominiklohmann dominiklohmann added bug Incorrect behavior engine Core pipeline and storage engine labels Apr 4, 2024
@dominiklohmann dominiklohmann requested a review from a team April 4, 2024 16:22
In some cases, pipelines created with a `tenzir` process connected to a
`tenzir-node` process did not shut down correctly when the `tenzir-node`
process was terminated. This change makes it so that remotely spawned
operators are always shut down reliably.

Fixes tenzir/issues#1712
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired the review with Dominik.

@dominiklohmann dominiklohmann merged commit 335a948 into main Apr 5, 2024
51 checks passed
@dominiklohmann dominiklohmann deleted the topic/remote-operator-shutdown branch April 5, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior engine Core pipeline and storage engine
Projects
None yet
2 participants