Remove wrong EXPOSE in Dockerfile #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
tobim
approved these changes
Apr 5, 2024
Our Docker images always exposed port 5158/tcp, regardless of how that was configured. This broke running multiple nodes in the same Docker Compose file or in host mode.
dominiklohmann
force-pushed
the
topic/remove-expose-in-dockerfile
branch
from
b6dd1d0
to
ef97949
Compare
tobim
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Docker images always exposed port 5158/tcp, regardless of how that was configured. This broke running multiple nodes in the same Docker Compose file or in host mode.