Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value grouping to chart and remove --title #4119

Merged
merged 7 commits into from Apr 15, 2024

Conversation

jachris
Copy link
Contributor

@jachris jachris commented Apr 15, 2024

This PR is basically #4111 without #4107 plus a few changes to make it work. The syntax for specifying multiple fields becomes -y foo,bar,baz. The appearance can be configured with --position stacked and --position grouped.

@jachris jachris added the feature New functionality label Apr 15, 2024
@jachris jachris force-pushed the topic/chart-value-grouping-2 branch from 3b1be16 to 58762cf Compare April 15, 2024 10:48
@jachris jachris marked this pull request as ready for review April 15, 2024 10:48
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this over. I went through the code and did try it briefly, and things seem to work expected.

changelog/next/changes/4111--chart-implicit-values.md Outdated Show resolved Hide resolved
libtenzir/builtins/operators/chart.cpp Outdated Show resolved Hide resolved
@jachris jachris enabled auto-merge April 15, 2024 11:10
@jachris jachris merged commit ae13262 into main Apr 15, 2024
51 checks passed
@jachris jachris deleted the topic/chart-value-grouping-2 branch April 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
3 participants