Revert "Annotate schemas with #index=hash" #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
changed the title
lava
force-pushed
the
topic/hash-index-revert
branch
from
77e8e34
to
64a5520
Compare
|
If we want to disable the hash index completely, we also need to disable the attribute inject heuristic in the Zeek parser. We should also write a changelog entry so users know why this index is disabled. |
dominiklohmann
requested changes
Feb 22, 2020
There was a problem hiding this comment.
This looks fine, but please address the changes requested by @tobim.
This reverts commit 9f656e8. When benchmarking, we discovered that the hash index introduces a huge performance regression for the `vast import suricata` command, due to a variant type being used as a key in a `flat_map`. Therefore, we're removing the hash indices until the underlying problem is fixed.
This reverts commit cc1b8e6. Remove hash indices due to performance regressions.
lava
added
performance
lava
force-pushed
the
topic/hash-index-revert
branch
from
64a5520
to
36d9286
Compare
dominiklohmann
approved these changes
Feb 25, 2020
lava
force-pushed
the
topic/hash-index-revert
branch
from
36d9286
to
e0c62b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 9f656e8.
When benchmarking, we discovered that the hash index introduces
a huge performance regression for the
vast import suricatacommand, due to a variant type being used as a key in a
flat_map.Therefore, we're removing the hash indices until the underlying
problem is fixed.