Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements for read_query() #878

Merged
merged 3 commits into from May 19, 2020
Merged

UX improvements for read_query() #878

merged 3 commits into from May 19, 2020

Conversation

lava
Copy link
Member

@lava lava commented May 19, 2020

This consists of two commits:

  1. Print a message when VAST is waiting for the user to input a query
  2. Print a deprecation warning when a query is spread over several command line arguments.

@lava lava requested a review from dominiklohmann May 19, 2020 10:08
dominiklohmann
dominiklohmann approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this to work on macOS as well. Approving as is.

Can you add a changelog entry for the deprecation?

lava added 3 commits May 19, 2020 14:19
@lava
Print message when user input is expected
67fadb2 
Print a message when we're trying to read a query from
stdin, for example because a user forgot to specify the
query argument in a command.
@lava
Print warning when query is spread over multiple arguments
7934091
@lava
Add CHANGELOG entries
a10767e
@lava lava force-pushed the topic/read-query-improvements branch from e938a26 to a10767e Compare May 19, 2020 12:20
@lava lava merged commit e9f1135 into master May 19, 2020
@lava lava deleted the topic/read-query-improvements branch May 19, 2020 13:10
@dominiklohmann dominiklohmann mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lava @mavam @dominiklohmann