Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for USDT tracepoints in VAST #1206

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Conversation

lava
Copy link
Member

@lava lava commented Nov 26, 2020

📔 Description

See extensive description in the new header file itself.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review all commits at once.

To verify that release builds now contain trace points by default:

  1. Download the CI artifact on a linux system
  2. Use sudo perf buildid-cache -a /path/to/libvast.so to add the binary to the buildid cache
  3. Use sudo perf probe --list | grep vast to see if the tracepoint exist
    (optionally)
  4. Use e.g. sudo perf probe sdt_vast:chunk_make and perf record -e sdt_vast:chunk_make -- vast start to record the samples

@lava lava changed the title Add support for USDT tracepoint in VAST Add support for USDT tracepoints in VAST Nov 26, 2020
@lava lava force-pushed the topic/usdt-tracepoints branch 5 times, most recently from 25e103e to 4ade0fb Compare November 26, 2020 16:54
@dominiklohmann
Copy link
Member

This requires Folly to be added to our Open-Source Licenses document. Do you want me to make this change?

@lava lava force-pushed the topic/usdt-tracepoints branch 3 times, most recently from bdd1102 to 2b30753 Compare November 30, 2020 16:44
@mavam mavam added the feature New functionality label Nov 30, 2020
@lava lava force-pushed the topic/usdt-tracepoints branch 3 times, most recently from b781968 to 2bca8d1 Compare December 1, 2020 14:52
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo passive voice in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@lava lava merged commit d9ae2f2 into master Dec 2, 2020
@lava lava deleted the topic/usdt-tracepoints branch December 2, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants