Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CLI options before initializing logger #1334

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Merge CLI options before initializing logger #1334

merged 2 commits into from
Feb 3, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

This fixes an issue where logger options were not recognized when passed on the command line.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Test locally.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Feb 3, 2021
@dominiklohmann dominiklohmann requested a review from a team February 3, 2021 10:38
tobim
tobim approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the immediate issue.

@dominiklohmann dominiklohmann merged commit 6602e45 into master Feb 3, 2021
@dominiklohmann dominiklohmann deleted the story/ch22449/log-options-cmdline branch February 3, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim