Enable real-time metrics reporting #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch21938/real-time-metrics
branch
2 times, most recently
from
2b52d5a
to
311e29a
Compare
0snap
approved these changes
Feb 15, 2021
This commit contains three changes: - It replaces underscores with dashes in vast.metrics.* options to be consistent with other options. - It removes the unused vast.metrics.enable option. Use vast.enable-metrics instead. - It adds a new options vast.metrics.real-time to enable real-time metrics reporting. This is disabled by default.
dominiklohmann
force-pushed
the
story/ch21938/real-time-metrics
branch
from
311e29a
to
f9bdb13
Compare
|
I rebased this onto recent master to fix the merge conflict in the changelog file. |
tobim
requested changes
Feb 15, 2021
tobim
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR contains three changes:
vast.metrics.*options to be consistent with other options.vast.metrics.enableoption. Usevast.enable-metricsinstead.vast.metrics.{file,uds}-sink.real-timeto enable real-time metrics reporting. This is disabled by default.📝 Checklist
🎯 Review Instructions
For @tenzir/backend: Review code file-by-file. Please also review the related documentation PR.
For @0snap, who requested this feature: Run locally and see if this suits your needs. You can create a static binary for this branch on-demand with the new "Run workflow" button on the actions page for the
VAST Staticworkflow. Edit: I've done this, you can find the run here.