Support optional numeric duration output for JSON #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VAST prints values of type `duration` as human-readable strings when printing JSON, e.g., `"5.9h"` or `"5.2m"`. For post-processing output, this is very inflexible because it requires custom parsing. The new option `vast.export.json.numeric-durations` enables numeric rather than human-readable output.
dominiklohmann
force-pushed
the
story/ch22913/json-numeric-durations
branch
from
2665cab
to
30a3169
Compare
mavam
approved these changes
May 5, 2021
< 200 for both now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
VAST prints values of type
durationas human-readable strings when printing JSON, e.g.,"5.9h"or"5.2m". For post-processing output, this is very inflexible because it requires custom parsing.The new option
vast.export.json.numeric-durationsenables numeric rather than human-readable output.📝 Checklist
🎯 Review Instructions
File-by-file. Test locally.