Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't abort startup if individual partitions fail to load #2515

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Don't abort startup if individual partitions fail to load #2515

merged 5 commits into from
Sep 23, 2022

Conversation

tobim
Copy link
Member

@tobim tobim commented Aug 19, 2022 •
edited by dominiklohmann
Loading

If something is wrong with a partition we now skip it instead of preventing VAST from starting up.

📝 Reviewer Checklist

Review this pull request by ensuring the following items:

  • All user-facing changes have changelog entries
  • User-facing changes are reflected on vast.io

@tobim tobim added the bug Incorrect behavior label Aug 19, 2022
@tobim tobim force-pushed the topic/improve-startup-resilience branch from 61acbff to 29db914 Compare August 22, 2022 10:31
@dominiklohmann dominiklohmann added the blocked Blocked by an (external) issue label Aug 26, 2022
dominiklohmann
dominiklohmann approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out by making select files unreadable to the user of the VAST process. This works as expected.

I added a blocked label so we can merge this only after the v2.3 release.

libvast/src/system/index.cpp Outdated Show resolved Hide resolved
libvast/src/system/index.cpp Outdated Show resolved Hide resolved
libvast/src/system/index.cpp Outdated Show resolved Hide resolved
@lava lava removed the blocked Blocked by an (external) issue label Sep 1, 2022
@tobim tobim force-pushed the topic/improve-startup-resilience branch 2 times, most recently from 43dac61 to e345d80 Compare September 23, 2022 10:50
tobim and others added 5 commits September 23, 2022 12:51
@tobim
Don't abort startup if individual partitions fail to load
54dc8db 
If something is wrong with a partition we now skip it instead of
preventing VAST from starting up.
@tobim
Add a changelog entry.
227c847
@tobim @dominiklohmann
Make error messages consistent
48b02e1 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
@tobim @dominiklohmann
Make error messages consistent
1be5e48 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
@tobim
Fix inconsitencies introduced by a rebase
8df618a
@tobim tobim force-pushed the topic/improve-startup-resilience branch from e345d80 to 8df618a Compare September 23, 2022 10:51
@tobim tobim merged commit ce71a59 into master Sep 23, 2022
@tobim tobim deleted the topic/improve-startup-resilience branch September 23, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@lava lava Awaiting requested review from lava

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @dominiklohmann @lava