Parser API design #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
parser-design
branch
from
49c69aa
to
005e350
Compare
teo-tsirpanis
force-pushed
the
parser-design
branch
from
005e350
to
2242794
Compare
This will allow accessing the context object from the `ParserState` instead of the `ParserInputReader`. The latter's `StateBox` property was removed.
The context can automatically return the character buffers all characters have been read and input has completed.
They can put a strain on the implementers and are not strictly necessary. Farkle 6 has a `Cast()` method for runtime Farkles which we might port.
And I liked this idea so much. 😭 The problem with it is that it restricts the API by prohibiting upcasting operations on parser and builder objects, and has a questionable advantage (zero allocations with the calculator)? Thankfully I just thought of a way to reintroduce an optimization like this in the future.
… tokenizer success or failure.
teo-tsirpanis
force-pushed
the
parser-design
branch
from
aa0ddeb
to
1178f69
Compare
Add `InputName` and make it and the `Context` get/set instead of get/init; you cannot init the parser state of a `ParserStateContext`.
It's not supposed to be modified by user code and `ParserStateContext` will still be able to set it to itself.
teo-tsirpanis
force-pushed
the
parser-design
branch
from
3f8c2e2
to
49cfbba
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.