Skip to content

Commit

Permalink
Some of #322: Make safari use at least supported in S::R::D
Browse files Browse the repository at this point in the history
Still need to work on the individual drivers
  • Loading branch information
teodesian authored and Andy committed Jan 20, 2018
1 parent 8c7e0ee commit 28ebc99
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/Selenium/Remote/Driver.pm
Expand Up @@ -199,6 +199,8 @@ That said, the following 'sanity tests' in the at/ (acceptance test) directory o
=item InternetExplorerDriver : 3.8.1 - at/sanity-ie.test (be sure to enable 'allow local files to run active content in your 'advanced settings' pane)
=item safaridriver : 11.0.2 - at/sanity-safari.test (be sure to enable 'allow automated testing' in the developer menu) -- it appears WC3 spec is *unimplemented*
=back
These tests are intended to be run directly against a working selenium server on the local host with said drivers configured.
Expand Down Expand Up @@ -228,7 +230,7 @@ Desired capabilities - HASH - Following options are accepted:
=item B<port> - <string> - Port on which the Webdriver server is listening. Default: 4444
=item B<browser_name> - <string> - desired browser string: {phantomjs|firefox|internet explorer|MicrosoftEdge|htmlunit|iphone|chrome}
=item B<browser_name> - <string> - desired browser string: {phantomjs|firefox|internet explorer|MicrosoftEdge|safari|htmlunit|iphone|chrome}
=item B<version> - <string> - desired browser version number
Expand Down Expand Up @@ -2359,10 +2361,10 @@ sub add_cookie {
'name' => $name,
'value' => $value,
'path' => $path,
'domain' => $domain,
'secure' => $secure,
}
};
$params->{cookie}->{domain} = $domain if $domain;
$params->{cookie}->{'httponly'} = $httponly if $httponly;
$params->{cookie}->{'expiry'} = $expiry if $expiry;

Expand Down

0 comments on commit 28ebc99

Please sign in to comment.