Temporarily fix Firefox platform problem #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks like it should work, but there's issues with the unit tests. I'll look at that when I can if you don't get to it first. |
|
They are version dependent. I don't have any problems with |
teodesian
reviewed
Mar 24, 2018
lib/Selenium/Remote/Driver.pm
Outdated
| 'javascriptEnabled' => $self->javascript, | ||
| 'version' => $self->version, | ||
| 'acceptSslCerts' => $self->accept_ssl_certs, | ||
| %$extra_capabilities, | ||
| }, | ||
| }; | ||
| $args->{'desiredCapabilities'}{'platform'} = $self->platform | ||
| if $self->browser_name ne 'firefox' || !$self->{is_wd3}; |
There was a problem hiding this comment.
what if we actually want to pass a platform other than 'ANY'? does that also cause the geckodriver to die?
There was a problem hiding this comment.
I tried imposing a few, same results.
There was a problem hiding this comment.
Dang. Sounds like a proper bug in the driver then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #375 until Firefox/Selenium can negociate again