Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #398: set_window_{position,size} validate args and convert to numeric #405

Merged
merged 2 commits into from Oct 13, 2018
Merged

Fix #398: set_window_{position,size} validate args and convert to numeric #405

merged 2 commits into from Oct 13, 2018

Conversation

tod222
Copy link
Contributor

@tod222 tod222 commented Oct 3, 2018

As we discussed a few weeks back.

@teodesian
Copy link
Owner

t/author-no-tabs.t ...................... 1/?

Failed test 'No tabs in 'lib/Selenium/Remote/Driver.pm' on line 1080'

Adjust that and we'll be clear for merge.

@teodesian teodesian mentioned this pull request Oct 12, 2018
Closed
@tod222
Copy link
Contributor Author

tod222 commented Oct 12, 2018

Ahh yes, just realized what this meant.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.457% when pulling 8990807 on tod222:issue-398 into 2071827 on teodesian:master.

@teodesian teodesian merged commit 8be4831 into teodesian:master Oct 13, 2018
@teodesian
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tod222 @teodesian @coveralls