Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the action type for button_up() #459

Merged
merged 3 commits into from Apr 6, 2023

Conversation

bschmalhofer
Copy link
Contributor

I have been looking at DragAndDrop failures of the Selenium tests for OTOBO. There I noticed that pointerDown was emitted twice. I think that the WebDriver action should be pointerUp instead of pointerDown for the sub button_up().

The WebDriver action should be pointerUp instead of pointerDown.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 62.052% when pulling 177a44d on bschmalhofer:bschmalhofer-patch-1 into c0f15ed on teodesian:master.

@bschmalhofer
Copy link
Contributor Author

I still think the the method button_up() should be fixed. I updated the PR, making sure it still applies to the current HEAD of master.

@teodesian teodesian merged commit 1bde1db into teodesian:master Apr 6, 2023
@teodesian
Copy link
Owner

Should be in 1.49, just uploaded to CPAN

@bschmalhofer bschmalhofer deleted the bschmalhofer-patch-1 branch April 6, 2023 18:33
@bschmalhofer
Copy link
Contributor Author

Thanks a bunch. I updated my required version of Selenium::Remote::Driver and closed RotherOSS/otobo#727 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants