easyTipViewDidDismiss not called when calling dismiss()

[theolof]

I expected easyTipViewDidDismiss to be called when doing
self.tipView.dismiss()
but it isn't.

I do that when the user taps an overlay.
easyTipViewDidDismiss is called when the user taps the tipView (so the delegate should be correct).

Is it an issue or am I holding it wrong?

[teodorpatras]

Delegation call hasn't been implemented in this case because you have the completion block that gets called after the view has been dismissed:

tipView.dismiss(withCompletion:{ _ in
     // code executed after the view has been dismissed
})

[theolof]

OK, so I have to call the same code as I do in easyTipViewDidDismiss.
I think it would have been cleaner to always do easyTipViewDidDismiss whenever the view has been dismissed, regardless of how it was dismissed.

It works though.

[teodorpatras]

Thanks for your insight, I'll make this feature available in next release.

[teodorpatras]

fyi fix applied in version 0.2.1

[theolof]

sweet!

[choujar]

I'm sorry, but I still can't work out how to perform actions when the user dismisses the tooltip by tapping on it (that seems like the default option, right?).

As in there doesn't seem to be a way to assign the delegate...

[choujar]

Hi folks, any update on this?

[theolof]

class TheViewController: UIViewController, EasyTipViewDelegate {
...
tipView = EasyTipView(text: "The text", preferences: preferences, delegate: self)
...
func easyTipViewDidDismiss(_ tipView: EasyTipView) {
...

That's my setup. When I click the tooltip, the function easyTipViewDidDismiss is called.