Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dependency on generated compose resources task for preBuild phase #11

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Feb 23, 2024

Introduce Dependency on Generated Compose Resources Task in preBuild Phase

This pull request adds a dependency on the newly created generateComposeResourcesForLocale${variant.name.capitalized()} task in the preBuild phase of the build process. This ensures that the generated Compose resources are available before the build starts, potentially improving performance and consistency.

Changes:

  • Renamed the task from generateSupportedLocalesTaskProvider to generateComposeResourcesForLocale${variant.name.capitalized()} to better reflect its purpose.
  • Updated the PR title, description, and commit title accordingly.
  • Maintained the logic of adding a dependency on this task in the preBuild phase for all variants.

Benefits:

  • Ensures that generated Compose resources are available before the build starts, potentially improving build performance and consistency.
  • Makes the build process more modular and easier to understand.

@teogor teogor added this to the 1.0.0-alpha02 milestone Feb 23, 2024
@teogor teogor self-assigned this Feb 23, 2024
@teogor teogor merged commit 79c8514 into main Feb 23, 2024
5 checks passed
@zeobot zeobot bot deleted the bugfix/compose-resources-prebuild-dependency branch February 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant