-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prove rdist_triangle
#60
Conversation
I think you modified the hypotheses of rdist_triangle slightly and this has caused the usage of rdist_triangle at HundredPercent.lean to be slightly off, see https://github.com/teorth/pfr/actions/runs/6960892058/job/18942193897?pr=60 . Are you able to edit HundredPercent.lean to make it compile again? If not I can try to fix it on my end. |
I should be able to edit it - I'm looking at it now. There seem to be other errors that are appearing (locally at least) in |
Hopefully this should work now! |
Still problematic unfortunately: https://github.com/teorth/pfr/actions/runs/6961920652/job/18944615099 |
That's weird - it worked locally. I'll have a look to see what's wrong with it |
I just realized I made some arguments implicit and forgot to make the corresponding modifications to |
So sorry, it's still reporting an issue: https://github.com/teorth/pfr/actions/runs/6962400483/job/18946551993?pr=60 |
GitHub CI for PR runs on a synthetic merge between the branch and master (in this particular case, the "Checkout project" build step for the latest CI run reports @Paul-Lez If you merge master, you will see the errors locally too. In fact, you'll see more errors than in this PR's last CI run, because of newer commits on master. |
I still need to make sure everything is fixed locally so it might be worth waiting a bit before running the CI |
Seems like the build failed again - I'll try and see what caused this |
Oof, that's frustrating but it does seem like the error messages are different at least so there is progress... |
Ah I think I found what happened! The hypotheses for |
Okay so what was causing an issue is that The other sorry I added to |
Looks like the build finished with no errors this time! |
Yay! It worked. You should comment on the Zulip on the changes so that other people can fix the relevant sorries. |
In this PR we prove the Ruzsa triangle inequality