Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues I found #26

Closed
rocky143 opened this issue Aug 4, 2015 · 4 comments
Closed

A few issues I found #26

rocky143 opened this issue Aug 4, 2015 · 4 comments
Assignees
Labels

Comments

@rocky143
Copy link

rocky143 commented Aug 4, 2015

After creating arenas, I found Yaw/Pitch was not saved to the arena file.
Not that its a big issue but it would be great if this can be fixed.

Here is the current duelarenas.yml https://i.gyazo.com/2790f6f3dce68bc11e73dbb54b095d83.png

Edit: Also, I found a few other issues.

  1. When blocked command typed, you get 2 same messages:
    http://i.imgur.com/6UDhZSE.png
  2. When invite a player, the invited player receives a message to accept + opens gui. Could the message be disabled?
    http://i.imgur.com/z4fqfQQ.png
  3. Inventory click error. Happens when a requested player clicks anywhere outside inventory:
    http://pastebin.com/XAUezGFn

Thanks in advanced!

@rocky143 rocky143 changed the title Yaw/Pitch not saving to duelarenas.yml Yaw/Pitch not saving to duelarenas.yml, /duel leave cmd spam & invite cmd msg Aug 4, 2015
@rocky143 rocky143 changed the title Yaw/Pitch not saving to duelarenas.yml, /duel leave cmd spam & invite cmd msg Yaw/Pitch not saving, /duel leave cmd spam & invite cmd msg Aug 4, 2015
@rocky143 rocky143 changed the title Yaw/Pitch not saving, /duel leave cmd spam & invite cmd msg A few issues I found Aug 4, 2015
@teozfrank
Copy link
Owner

  • After creating arenas, I found Yaw/Pitch was not saved to the arena file.
    Its not meant to be saved to the file.

1.This should be fixed.
2. This is also fixed will send the message OR open the gui menu depending on the settings in config.yml
3. This should also be fixed.

Checkout the latest update in spigot to check if these problems are gone, besides the yaw / pitch as its intentional, not a bug. Will be uploaded in a few mins.

teozfrank added a commit that referenced this issue Aug 4, 2015
1. When blocked command typed, you get 2 same messages:
2. When invite a player, the invited player receives a message to accept + opens gui. Could the message be disabled?
3. Inventory click error. Happens when a requested player clicks anywhere outside inventory.

Adds new config options to config.yml to enable / disable gui menus, and a max duel bet amount.

As reported in issue #26

Release 0.9.15.1
@teozfrank teozfrank added the bug label Aug 4, 2015
@teozfrank teozfrank self-assigned this Aug 4, 2015
@rocky143
Copy link
Author

rocky143 commented Aug 5, 2015

Thank you very much for the quick fixes. You have done a great job. I have sent you a little donation and will donate more in the future when possible.

For Yaw and Pitch. Since its not saved to the file, when the server restarts and player joins the arena, they only face to Yaw: 0.0 and Pitch: 0.0. In some cases, they would face the area walls.
Its nothing urgent but if you ever have some spare time. As a request, please add the saving of it.

Also, for win rewards. I found it really difficult to disable since if I remove the command for reward.
It still messages the player "You have won the duel! here is your prize!"
https://i.gyazo.com/2ff6754a2a0c21e0711f87a24391f1c5.png

Really appreciate you effort on your amazing plugin!

@teozfrank
Copy link
Owner

Thank you for your donation, I will add that when I get the time to do so. I will look at the messages too again when I get the time. Thanks.

@teozfrank
Copy link
Owner

Yaw and Pitch have been added in the latest update, you will need to set your spawnpoints on each arena to see the effect.

Repository owner locked and limited conversation to collaborators Sep 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants