Open DateFilterPopup for subclassing #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepi
added a commit
that referenced
this pull request
Jan 20, 2016
Open DateFilterPopup for subclassing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really like your DateFilterPopup. We use it also in other cases beside the FilterTable.
However, DateFilterPopup is not opened for subclassing. It would be nice if we can hook into the building of the popup and access the components to add additional functionality.
Our concrete use cases: We like to change the value of the toField if the fromField has been changed. Therefore, we need to add a ValueChangeListener to the fromField in the subclass.
To achieve this (and similar use cases) I suppose to change the visibility of the DateFields, Buttons, the PopupButton and the method buildPopup() to protected. This way subclasses can overwrite buildPopup() and add additional logic using the components.
Best Regards
Philipp