Merge pull request #49 from teppeis/check-extending-interface

Add check for @extends using with @interface.

lib/parser.js

@@ -173,7 +173,7 @@ Parser.prototype.extractToRequire_ = function(parsed, toProvide, comments, opt_r
 };
 
 /**
- * Require "@implements" classes.
+ * Require "@implements" classes and "@extends" classes with "@interface".
  * @param {Array} comments .
  * @return {Array.<string>} .
  * @private
@@ -188,9 +188,28 @@ Parser.prototype.extractToRequireFromJsDoc_ = function(comments) {
       if (tag.title === 'implements' && tag.type.type === 'NameExpression') {
         prev.push(tag.type.name);
       }
-    });
+      if (tag.title === 'extends' && tag.type.type === 'NameExpression' &&
+          this.containsJsDocTag_(jsdoc, 'interface')) {
+        prev.push(tag.type.name);
+      }
+    }, this);
     return prev;
-  }, []);
+  }.bind(this), []);
+};
+
+/**
+ * @param {!Object} jsdoc .
+ * @param {string} tagName .
+ * @return {boolean} .
+ * @private
+ */
+Parser.prototype.containsJsDocTag_ = function(jsdoc, tagName) {
+  for (var i in jsdoc.tags) {
+    if (jsdoc.tags[i].title === tagName) {
+      return true;
+    }
+  }
+  return false;
 };
 
 /**

test/fixtures/parse/@extends.js

@@ -0,0 +1,15 @@
+/**
+ * @interface
+ * @extends {goog.disposable.IDisposable}
+ */
+var Foo = function() {
+};
+
+/**
+ * @constructor
+ * @extends {goog.Disposable}
+ */
+var Foo = function() {
+};
+
+// toRequire: goog.disposable.IDisposable