Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking the output image-name and the download.links.list #15

Closed
rayjs opened this issue Jan 2, 2018 · 6 comments
Closed

Linking the output image-name and the download.links.list #15

rayjs opened this issue Jan 2, 2018 · 6 comments
Assignees
Labels

Comments

@rayjs
Copy link

rayjs commented Jan 2, 2018

Hi again,

I have two questions:
a) I was wondering if it is possible to link the line number in download.links.list file and the saved image name. For e.g the image name can correspond to the line num in download.links.list file. The other way round is to redownload with the download.links.list file and establish the correspondence, but this would involve downloading twice.

b) I noticed even with the -s flag sometimes I do not have download.links.list file in the img sub dir. Any known reasons?

@rayjs
Copy link
Author

rayjs commented Jan 2, 2018

I just checked I think there is one-to-one correspondence in the image index number and the download.links.list file. So please scratch that question.

However even with the -s flag I do not get the download.links.list file.

Here is my command:
./googliser.sh -p "$line" --type photo -n 350 -r 5 -s -m vga -o /path/to/folder/"$line" -P 10 -N

@rayjs
Copy link
Author

rayjs commented Jan 2, 2018

So it seems whenever the script cannot download X number of images as specified by the argument -n X it does not write the download.links.list file.

@rayjs
Copy link
Author

rayjs commented Jan 2, 2018

It works now after commenting out the following if condition:
https://github.com/teracow/googliser/blob/master/googliser.sh#L891

@teracow
Copy link
Owner

teracow commented Jan 2, 2018

Hey @rayjs. :)

Good pickup. You found a set of conditions I hadn't planned on or tested for.

I'll change that line so it will copy the links even if the downloader runs out of images.

Thanks!

@teracow teracow closed this as completed in 2b33293 Jan 2, 2018
@teracow teracow self-assigned this Jan 2, 2018
@teracow teracow added the bug label Jan 2, 2018
@teracow
Copy link
Owner

teracow commented Jan 2, 2018

Also, I noticed you're using a variable called $line for your phrase. You might be interested in a feature I added a while back to read a list of phrases from file. Check out the -i or --input parameter.

@rayjs
Copy link
Author

rayjs commented Jan 2, 2018

Did not know that. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants