Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should add cert.generated: true option to enable/disable cert generation #23

Closed
hoatle opened this issue Dec 3, 2018 · 0 comments
Closed

should add cert.generated: true option to enable/disable cert generation #23

hoatle opened this issue Dec 3, 2018 · 0 comments
Assignees
@hieptranquoc
Labels
affected:develop affected on the develop branch affected:v0.3.0 affected on the v0.3.0 version prio:major reso:fixed type:improvement
Milestone
v0.4.0-dev-certs

Comments

@hoatle
Copy link
Member

hoatle commented Dec 3, 2018 •
edited
Loading

There is a case that we need a root CA generated only, not a certificate. So this option is introduced. It's enabled by default (to keep the same behavior as before), users can override to disable cert generation.

default:

teracy-dev-certs:
 # cert_days: 200 # deprecate this
  cert:
    days: 200
    generated: true # enabled by default to generate a CA signed certificate

users can override:

teracy-dev-certs:
  cert:
    generated: false # or 0, no

use https://github.com/teracyhq/dev/blob/develop/lib/teracy-dev/util.rb#L38 to check boolean value.
@hoatle hoatle added type:improvement prio:major sprt:next affected:develop affected on the develop branch affected:v0.2.0 affected on the v0.2.0 version labels Dec 3, 2018
@hoatle hoatle added this to the v0.3.0-dev-certs milestone Dec 3, 2018
@hoatle hoatle changed the title should add cert_generated: true option to enable/disable cert generation should add cert.generated: true option to enable/disable cert generation Dec 10, 2018
@hoatle hoatle added affected:v0.3.0 affected on the v0.3.0 version and removed affected:v0.2.0 affected on the v0.2.0 version labels Dec 10, 2018
hieptranquoc added a commit to hieptranquoc/teracy-dev-certs that referenced this issue Jan 7, 2019
@hieptranquoc
@ teracyhq-incubator#23 | add generate option and deprecated cert_days
590be59
@hieptranquoc hieptranquoc mentioned this issue Jan 7, 2019
Merged
@ghost ghost added stag:in-progress and removed sprt:current labels Jan 7, 2019
@hoatle hoatle assigned datphan and unassigned hieptranquoc Jan 7, 2019
hoatle added a commit that referenced this issue Jan 17, 2019
@hoatle
Merge pull request #28 from hieptranquoc/improvement/#23-add-option-e…
9a4ebc4 
…nable-or-disable-cert-generation

@ #23 | add generate option and deprecated cert_days
@hoatle hoatle assigned hoatle and unassigned datphan Jan 17, 2019
@hoatle hoatle assigned hieptranquoc and unassigned hoatle Jan 17, 2019
@hoatle hoatle closed this as completed Jan 17, 2019
@ghost ghost removed the stag:under-verification label Jan 17, 2019
hoatle added a commit that referenced this issue Jan 22, 2019
@hoatle
@ #23 #27 | update README for the changes
010448a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hieptranquoc hieptranquoc

Labels
affected:develop affected on the develop branch affected:v0.3.0 affected on the v0.3.0 version prio:major reso:fixed type:improvement
Projects
None yet
Milestone
v0.4.0-dev-certs
Development

No branches or pull requests
3 participants
@hoatle @datphan @hieptranquoc