@ #11 | should add docs how to get SSO work with Dex #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hieptranquoc
approved these changes
Oct 16, 2018
|
I've reviewed! @hoavt please check grammar and review |
hoavt
reviewed
Oct 17, 2018
docs/sso.md
Outdated
| # SSO (Single Sign On with Kubernetes) | ||
|
|
||
| This guide will help you to set up SSO for k8s. You should set up a local k8s to test this on local | ||
| by following https://github.com/teracyhq-incubator/teracy-dev-entry-k8s#how-to-use |
There was a problem hiding this comment.
should have a full stop at the end of the sentence
docs/sso.md
Outdated
| ## Domain Aliases | ||
|
|
||
| We're going to deploy dex (auth.k8s.local) and dex-k8s-authenticator (login.k8s.local) helm charts, | ||
| so make sure to configure these domain aliases (see https://github.com/teracyhq-incubator/teracy-dev-entry-k8s#domain-aliases) |
There was a problem hiding this comment.
should have a full stop at the end of the sentence
docs/sso.md
Outdated
| $ helm upgrade --install --namespace dex dex stable/dex -f dex.yaml | ||
| ``` | ||
|
|
||
| After that, `https://auth.k8s.local/.well-known/openid-configuration` should display info such as: |
docs/sso.md
Outdated
|
|
||
| `$ kubectl -n dex get configmaps dex-web-server-ca -o yaml` to see the dex CA root certifcate that | ||
| the k8s api server must trust and the dex client apps must trust when the self-signed certificate is | ||
| used for the dex deployment. Create `sso/dex-ca.pem` file from the config map data above. |
There was a problem hiding this comment.
Create the sso/dex-ca.pem file
docs/sso.md
Outdated
|
|
||
| ## Configure the k8s api server | ||
|
|
||
| Set the ansible config, through the `workspace/inventory/group_vars/k8s-cluster/k8s-cluster.yaml` or though the teracy-dev-k8s host_vars config: |
docs/sso.md
Outdated
| helm upgrade --install --namespace dex login charts/dex-k8s-authenticator -f dex-k8s-authenticator.yaml | ||
| ``` | ||
|
|
||
| and open https://login.k8s.local for the k8s login instruction |
There was a problem hiding this comment.
Should have a full stop at the end of the sentence.
…x: apply review comments
|
@hoavt review comments applied, pls continue the review. |
hoavt
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #11
assigned to @hieptranquoc to review the technical content, @hoavt to review the English grammar.