Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ #28 | add docs how to install kubectl helm #78

Conversation

hieptranquoc
Copy link
Contributor

connect #28
please check this PR! Thank you.

Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hieptranquoc please check my comments

$ brew link --overwrite kubernetes-cli # to ensure override new kubectl version to path
```

+ Install latest version with `kubectl` binary using `curl`(please install `curl` if you don't have it).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don;t need to mention the installation with curl. Just installation with brew is enough.


- Specific version:

+ If you have ever installed the desired version with `homebrew`, you can downgrade to that version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can switch to that version.

(we use the "switch" word, because we can switch from an old version to the newer version)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hieptranquoc I mean, we should use the word "switch", not "downgrade".

@@ -0,0 +1,448 @@
This page shows you how to install kubectl and helm on macOS, Linux (Ubuntu) and Windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume:
Assume:
homebrew available on macOS
chocolatey available on Windows
Ubuntu is preferred Linux distro

@hieptranquoc so we should show this, moreover, teracy-dev users have had them.

  • I don;t see the section how to upgrade the version.


If you installed `kubectl` using the Homebrew instructions then `kubectl` completion should start working immediately.

> If bash-completion in Homebrew not work, please add to `~/.bash_profile`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work

@hieptranquoc
Copy link
Contributor Author

Reply to all @hoavt comments: we can't switch version if we haven't installed it yet. So we need curl to install any version, include ( downgrade, upgrade ).

Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hieptranquoc@cae56c9#diff-5bda4a488e3bf7ddca37c694c0c16c92L115

why don;t show how to upgrade a newer version @hieptranquoc?


### Install

- Latest version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we mention 2 ways to install, the structure should be

  • Install Kubectl with brew
  • Install Kubectl with curl

And remove the unnecessary lines.

docs/how-to-install-kubectl-helm.md Show resolved Hide resolved
@hoavt hoavt removed their assignment Mar 28, 2019
@hieptranquoc hieptranquoc force-pushed the tasks/#28-add-docs-how-to-install-kubectl-helm branch from cae56c9 to 5888a0a Compare May 6, 2019 09:14
@hieptranquoc
Copy link
Contributor Author

I've updated! Please check this PR again!

Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my changes @hieptranquoc.

docs/how-to-install-kubectl-helm.md Outdated Show resolved Hide resolved
@hieptranquoc hieptranquoc force-pushed the tasks/#28-add-docs-how-to-install-kubectl-helm branch from a96e50d to 23bd1e1 Compare May 9, 2019 08:48
@hieptranquoc
Copy link
Contributor Author

@hoavt I've updated! Please check this PR again!

@hieptranquoc
Copy link
Contributor Author

@hoatle Please check! All done!

@hoatle
Copy link
Member

hoatle commented May 10, 2019

need @hoavt to approve this.

hoavt
hoavt previously approved these changes May 13, 2019
Copy link
Member

@hoatle hoatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hieptranquoc please check my comments.

# Requirements:
- Homebrew available on macOS
- Chocolatey available on Windows
- At least ubuntu 16.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu


This guide consists of two main sections:
- [Kubectl](#kubectl)
+ [Installing / Uninstalling kubeclt on macOS](#kubectl_mac_os)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl

This guide consists of two main sections:
- [Kubectl](#kubectl)
+ [Installing / Uninstalling kubeclt on macOS](#kubectl_mac_os)
+ [Installing / Uninstalling kubeclt on Linux(Ubuntu)](#kubectl_linux)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl

- [Kubectl](#kubectl)
+ [Installing / Uninstalling kubeclt on macOS](#kubectl_mac_os)
+ [Installing / Uninstalling kubeclt on Linux(Ubuntu)](#kubectl_linux)
+ [Installing / Uninstalling kubeclt on Windows](#kubectl_windows)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl


- Install a specific version [from the binary release](https://docs.helm.sh/using_helm/#from-the-binary-releases).

- Test `kubectl` version you installed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm


### Installing kubeclt on macOS

- Install kubeclt with `homebrew`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl

$ brew info kubernetes-cli
$ brew switch kubernetes-cli 1.12.0 # example downgrade to version 1.12.0
```
- Downgrade kubeclt with `homebrew`: See the details at https://www.benpickles.com/articles/72-downgrading-kubectl-with-homebrew to downgrade with `homebrew`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl

```
- Downgrade kubeclt with `homebrew`: See the details at https://www.benpickles.com/articles/72-downgrading-kubectl-with-homebrew to downgrade with `homebrew`.

- Install a kubeclt specific version with `curl`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl

$ kubectl version
```

### Uninstalling kubeclt on macOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl


> Note: **kubectl autocompletion will only work with `kubectl`, not `kubectl.exe`**.

# <a name="helm">Helm[Helm]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm[Helm] => Helm

Fix some spelling errors
Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied comments @hoatle

Copy link
Member

@hoatle hoatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoatle hoatle merged commit 8308f34 into teracyhq-incubator:develop May 14, 2019
@ghost ghost removed the stag:under-review label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants