Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should fix the bug related to config override within a project's dev-setup #400

Closed
hoatle opened this issue Aug 27, 2017 · 5 comments
Closed

Comments

@hoatle
Copy link
Member

hoatle commented Aug 27, 2017

please check this project: https://github.com/hoatle/teracy-dev-override-bug and follow the README file to reproduce

To fix this:

  • unit tests are required to reproduce the bug
  • code changes to pass the failing unit tests
@hoatle
Copy link
Member Author

hoatle commented Aug 28, 2017

there is a workaround by adding:

      "data_configs": [{
        "_id": "data_configs_0"
      }]

into the workspace/dev-setup/vagrant_config_default.json file

@phuonglm
Copy link
Contributor

phuonglm commented Sep 28, 2017

I'm going to update the strategy/order of config merge as follows:
Old order:
(teracy-dev + teracy-dev-override) + (org + org-override) + (project1 + project1-override)
New order:
(( teracy-dev + org) + ( teracy-dev-override + org_override)) + project1 + .. + projectx + project1_override + .. + projectx_override

The new order lets the default configuration build the frame, then we can use override configuration files to change the frame.

@hoatle
Copy link
Member Author

hoatle commented Oct 12, 2017

seems that we have a regression here, please see: #386 (comment)

@hoatle
Copy link
Member Author

hoatle commented Nov 28, 2017

@phuonglm I'll possibly revert the related code changes for this in 12 hours until we get the working solution to prevent blocking other devs to continue working on the develop branch. This issue is blocking for such a long time without any progress.

hoatle added a commit that referenced this issue Dec 4, 2017
@hoatle
Copy link
Member Author

hoatle commented Dec 4, 2017

reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants