Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ #257 | should remove the duplicated entry on the hosts file on the guest VM machine #258

Merged
merged 2 commits into from Feb 13, 2017
Merged

@ #257 | should remove the duplicated entry on the hosts file on the guest VM machine #258

merged 2 commits into from Feb 13, 2017

Conversation

hoatle
Copy link
Member

@hoatle hoatle commented Feb 12, 2017 •
edited

connects #257

this PR is currently acceptable:

$ cat /etc/hosts
127.0.0.1		teracy-2
127.0.0.1	localhost

The expected output below is great, can you recommend how to make this great @phuonglm?

$ cat /etc/hosts
127.0.0.1	teracy-2
127.0.0.1	localhost

@hoatle hoatle requested a review from phuonglm February 12, 2017 12:00
@hoatle
@ teracyhq#257 | should remove the duplicated entry on the hosts file…
ea04935 
… on the guest VM machine: get it perfect thanks to @phuonglm's suggestion
@hoatle hoatle assigned hoatle and unassigned phuonglm Feb 13, 2017
@hoatle
Copy link
Member Author

hoatle commented Feb 13, 2017

timeout for review, merged.

@hoatle hoatle merged commit adae118 into teracyhq:develop Feb 13, 2017
@hoatle hoatle deleted the bugs/#257-duplicated-hosts-entry-remove branch August 25, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phuonglm phuonglm Awaiting requested review from phuonglm

Assignees

@hoatle hoatle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoatle @phuonglm