Update flutter_web_auth to flutter_web_auth_2?
#137
Comments
|
@okrad if you have nothing against, I can take care of the migration. There's no contact with the author of the original package (which you can see e.g. under this PR, that was made to support Flutter 3: LinusU/flutter_web_auth#118) so moving on to a new fork seems like the only option. |
|
@ThexXTURBOXx, @PiotrMitkowski sorry for the late reply, I'm quite busy ATM... I too am under the impression that flutter_web_auth is in a stale state, and was already looking for other viable solutions. If you are willing to carry on the fork it would be great! There are definitely a couple of PRs that I'd like to see merged, starting with Linux support... @PiotrMitkowski, I'd gladly accept a PR for the migration. Can you update the README too? Thank you! |
|
@okrad Yes, I am trying to keep my fork as up-to-date as possible. Also, i was already merging many PRs that added Windows support, better support for Android, MacOS and iOS and so on. Anyways: Thanks for the response despite you being busy! |
|
@okrad @ThexXTURBOXx No problem, I'll land the PR soon. |
|
This is done :) |
42: fix: fixed for the issue (#41) r=myConsciousness a=myConsciousness # 1. Description <!-- Provide a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If this is a breaking change, specify explicitly which APIs have been changed. --> Version `1.0.0` introduced some breaking changes that need to be addressed if you are upgrading from previous versions. Please take note of the following: - From version 3.0.0, `flutter_web_auth` has been replaced by [`flutter_web_auth_2`](https://pub.dev/packages/flutter_web_auth_2). Please refer to the [upgrade instructions](https://pub.dev/packages/flutter_web_auth_2#upgrading-from-flutter_web_auth). - The migration to [`flutter_web_auth_2`](https://pub.dev/packages/flutter_web_auth_2) marks the transition to `Flutter 3`. This means that you must upgrade to `Flutter 3` (a simple `flutter upgrade` should be enough). ## 1.1. Checklist <!-- Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. --> - [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc). - [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs. - [x] I have updated/added tests for ALL new/updated/fixed functionality. - [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`. - [x] I have updated/added relevant examples in `examples`. ## 1.2. Breaking Change <!-- Does your PR require users to manually update their apps to accommodate your change? If the PR is a breaking change this should be indicated with suffix "!" (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details. --> - [x] Yes, this is a breaking change. - [ ] No, this is _not_ a breaking change. ## 1.3. Related Issues teranetsrl/oauth2_client#137 <!-- Provide a list of issues related to this PR from the [issue database]. Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !--> <!-- Links --> [issue database]: https://github.com/twitter-dart/twitter-oauth2-pkce/issues [contributor guide]: https://github.com/twitter-dart/twitter-oauth2-pkce/blob/main/CONTRIBUTING.md [style guide]: https://github.com/twitter-dart/twitter-oauth2-pkce/blob/main/STYLEGUIDE.md [conventional commit]: https://conventionalcommits.org Co-authored-by: myConsciousness <kato.shinya.dev@gmail.com>
I finally took the initiative and updated
flutter_web_authfor proper Flutter 3 support (using noga-dev's changes) and some more stuff!The new package is available here: https://pub.dev/packages/flutter_web_auth_2
Since I think that my updated package is only compatible with Flutter 3+, it might be worth noting this as a breaking change and providing a new major version number for the users
Edit: I forgot to mention that migrating is pretty easy: https://pub.dev/packages/flutter_web_auth_2#upgrading-from-flutter_web_auth
The text was updated successfully, but these errors were encountered: