Add new for TSError and use reject.toThrow

terascope · Jan 28, 2021 · 6f98a7f · 6f98a7f
1 parent 11836b6
commit 6f98a7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/teraslice/lib/cluster/services/cluster/backends/kubernetes/k8s.js b/packages/teraslice/lib/cluster/services/cluster/backends/kubernetes/k8s.js
@@ -204,9 +204,9 @@ class K8s {
         } if (jobs.items.length === 0) {
             const msg = `Teraslice ${objType} matching the following selector was not found: ${selector} (retriable)`;
             this.logger.warn(msg);
-            throw TSError(msg, { retryable: true });
+            throw new TSError(msg, { retryable: true });
         } else {
-            throw TSError(`Unexpected number of Teraslice ${objType}s matching the following selector: ${selector}`, {
+            throw new TSError(`Unexpected number of Teraslice ${objType}s matching the following selector: ${selector}`, {
                 retryable: true
             });
         }

diff --git a/packages/teraslice/test/lib/cluster/services/cluster/backends/kubernetes/k8s-spec.js b/packages/teraslice/test/lib/cluster/services/cluster/backends/kubernetes/k8s-spec.js
@@ -121,13 +121,8 @@ describe('k8s', () => {
                 .query({ labelSelector: 'app=teraslice' })
                 .reply(200, { items: [] });
 
-            try {
-                await k8s.nonEmptyList('app=teraslice', 'jobs');
-            } catch (error) {
-                expect(error).toEqual(
-                    Error('Teraslice jobs matching the following selector was not found: app=teraslice (retriable)')
-                );
-            }
+            await expect(k8s.nonEmptyList('app=teraslice', 'jobs'))
+                .rejects.toThrowError('Teraslice jobs matching the following selector was not found: app=teraslice (retriable)');
         });
     });