Fix parsing values when valueMirror.children is empty #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! That looks ok. Omitting the "?" was indeed an error. You're right that there should be a test for this, I'll add one. |
terhechte
added a commit
that referenced
this pull request
Jan 30, 2016
Fix parsing values when valueMirror.children is empty
|
Cool 👍. Are you planning to release the 0.1.3 version to CocoaPods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've found bug when relationship one-to-many does not contain any values it triggers "Could not decode value for field ...". And when I removed the question mark it was ok.
But I think there should be some tests, so we can be sure that this is working properly.